Skip to content

SectorNordAG: Fix for AnalyzePackageFrameworkRequirements #774

Open
LuBroering wants to merge 1 commit intoznuny:devfrom
SectorNordAG:AnalyzePackageFrameworkRequirementsFix
Open

SectorNordAG: Fix for AnalyzePackageFrameworkRequirements #774
LuBroering wants to merge 1 commit intoznuny:devfrom
SectorNordAG:AnalyzePackageFrameworkRequirementsFix

Conversation

@LuBroering
Copy link
Copy Markdown
Contributor

Proposed change

This Fix should implement the correct behavior for Version checks.

Type of change

  • '1 - 🐞 bug 🐞'

Additional information

A package with <Framework Minimum="7.2.1">7.x</Framework> can currently be installed on Znuny 7.1.7, as the check continues after correctly setting FWCheck to 0 or 1. The same logic applies to Maximum.

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant